[
https://issues.apache.org/jira/browse/HBASE-26458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446055#comment-17446055
]
Joel Swiatek commented on HBASE-26458:
--------------------------------------
After more discussion on the PR https://github.com/apache/hbase/pull/3852 and
offline, we are going to document existing behavior for master and branch-2 and
apply a code fix to branch-1.
The code fixes for master and branch-2 require changing behavior of protobufs,
which is incompatible and can create inconsistent RPC payloads during rolling
upgrades.
> Value of hbase.master.snapshot.ttl is not used
> ----------------------------------------------
>
> Key: HBASE-26458
> URL: https://issues.apache.org/jira/browse/HBASE-26458
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 1.7.1, 2.4.8
> Reporter: Joel Swiatek
> Assignee: Joel Swiatek
> Priority: Minor
> Fix For: 1.7.1, 2.4.8
>
> Attachments:
> branch-1-0001-HBASE-22458-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defa.patch,
> branch-2-0001-HBASE-22458-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defa.patch,
> master-0001-HBASE-22458-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defa.patch
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> When creating a snapshot, users can explicitly specify the TTL to be used. If
> no TTL is specified, then the SnapshotDescription is initially created with a
> TTL of -1 to indicate FOREVER.
> When the SnapshotDescription runs through SnapshotDescriptionUtils#validate,
> the TTL is checked to see if the default value of hbase.master.snapshot.ttl
> should be applied. The value from the config is only applied if the TTL == 0,
> but it should be -1.
> This has another nasty side-effect: any user who creates a snapshot and
> explicitly sets \{TTL => 0} will find that their snapshot gets its TTL from
> hbase.master.snapshot.TTL.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
