virajjasani commented on a change in pull request #3857:
URL: https://github.com/apache/hbase/pull/3857#discussion_r755006739
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
##########
@@ -3712,7 +3712,10 @@ public void snapshot(final String snapshotName, final
TableName tableName,
builder.setTable(tableName.getNameAsString());
builder.setName(snapshotName);
builder.setType(type);
- builder.setTtl(getTtlFromSnapshotProps(snapshotProps));
+ long ttl = getTtlFromSnapshotProps(snapshotProps);
+ if (ttl != 1L && ttl < TimeUnit.MILLISECONDS.toSeconds(Long.MAX_VALUE)) {
Review comment:
This would be `ttl != -1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
