[
https://issues.apache.org/jira/browse/HBASE-26458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-26458:
---------------------------------
Fix Version/s: 3.0.0-alpha-2
1.7.2
(was: 1.7.1)
(was: 2.4.8)
Hadoop Flags: Reviewed
Release Note: (was: Fixed bug where hbase.master.snapshot.ttl was not
respected.)
Resolution: Fixed
Status: Resolved (was: Patch Available)
The code fix is merged to branch-1 and the documentation is improved on master
branch.
Thanks for the contribution [~jswi].
> Value of hbase.master.snapshot.ttl is not used
> ----------------------------------------------
>
> Key: HBASE-26458
> URL: https://issues.apache.org/jira/browse/HBASE-26458
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 1.7.1, 2.4.8
> Reporter: Joel Swiatek
> Assignee: Joel Swiatek
> Priority: Minor
> Fix For: 3.0.0-alpha-2, 1.7.2
>
> Attachments:
> branch-1-0001-HBASE-22458-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defa.patch,
> branch-2-0001-HBASE-22458-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defa.patch,
> master-0001-HBASE-22458-Add-UNSET_SNAPSHOT_PROP-and-fix-TTL-defa.patch
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> When creating a snapshot, users can explicitly specify the TTL to be used. If
> no TTL is specified, then the SnapshotDescription is initially created with a
> TTL of -1 to indicate FOREVER.
> When the SnapshotDescription runs through SnapshotDescriptionUtils#validate,
> the TTL is checked to see if the default value of hbase.master.snapshot.ttl
> should be applied. The value from the config is only applied if the TTL == 0,
> but it should be -1.
> This has another nasty side-effect: any user who creates a snapshot and
> explicitly sets \{TTL => 0} will find that their snapshot gets its TTL from
> hbase.master.snapshot.TTL.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
