YutSean commented on a change in pull request #3883:
URL: https://github.com/apache/hbase/pull/3883#discussion_r758283027
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java
##########
@@ -47,4 +46,42 @@ public long getTimestampStarted() {
public long getTotalOpsProcessed() {
return totalOpsProcessed;
}
+
+ public static ReplicationLoadSinkBuilder newBuilder() {
Review comment:
I found that some other class has the same builder pattern, like
ReplicationLoadSource. Should we also change that class? I concern that builder
pattern will make too many extra small java files in this way. Or we write
builders in a factory class and generate builder for those class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
