Apache9 commented on a change in pull request #3903:
URL: https://github.com/apache/hbase/pull/3903#discussion_r760315810
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
##########
@@ -237,8 +237,8 @@ public AsyncFSWAL(FileSystem fs, Abortable abortable, Path
rootDir, String logDi
ThreadPoolExecutor threadPool =
new ThreadPoolExecutor(1, 1, 0L,
TimeUnit.MILLISECONDS, new LinkedBlockingQueue<Runnable>(),
- new ThreadFactoryBuilder().setNameFormat("AsyncFSWAL-%d-" +
rootDir.toString()).
- setDaemon(true).build());
+ new ThreadFactoryBuilder().setNameFormat("AsyncFSWAL-%d-prefix:" +
Review comment:
I prefer we still add the rootDir to the name? We can append the prefix
after rootDir.toString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
