BukrosSzabolcs commented on a change in pull request #3861:
URL: https://github.com/apache/hbase/pull/3861#discussion_r760940783
##########
File path:
hbase-protocol-shaded/src/main/protobuf/server/master/RegionServerStatus.proto
##########
@@ -230,4 +242,8 @@ service RegionServerStatusService {
/** Get some live region servers to be used as seed for bootstrap nodes */
rpc GetLiveRegionServers(GetLiveRegionServersRequest)
returns(GetLiveRegionServersResponse);
+
+ /** Report BrokenStoreFileCleaner chore metrics to master */
+ rpc ReportBrokenStoreFileCleanerUsage(BrokenStoreFileCleanerUsageRequest)
Review comment:
Usually we do not report metrics. I do this here for 2 reasons:
- Convenience. Aggregating the rs metrics is possible and usually done by
queries from the db, storing aggregated metrics here is for ease of use.
- Preparing things for the next PR where I'll add logic to store the
reported metrics in-memory and extend the REST service to allow checking these
values without having to access the metrics db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
