Apache9 commented on a change in pull request #3921:
URL: https://github.com/apache/hbase/pull/3921#discussion_r762656477



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
##########
@@ -545,4 +549,11 @@ private void restoreSnapshotAcl(final MasterProcedureEnv 
env) throws IOException
         env.getMasterServices().getConfiguration());
     }
   }
+
+  /**
+   * Exposed for Testing: HBASE-26462
+   */
+  public boolean getRestoreAcl() {

Review comment:
       Ditto.

##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java
##########
@@ -521,4 +526,11 @@ private void addRegionsToMeta(final MasterProcedureEnv 
env) throws IOException {
     
metaChanges.updateMetaParentRegions(env.getMasterServices().getConnection(), 
newRegions);
   }
 
+  /**
+   * Exposed for Testing: HBASE-26462
+   */
+  public boolean getRestoreAcl() {

Review comment:
       Please add a RestrictedApi annotation to limit the usage only in tests.
   
   This is an example:
   
   
https://github.com/apache/hbase/blob/dcd622d702c9300d81f66756308e4dbe801b1acf/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractRpcBasedConnectionRegistry.java#L224




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to