joshelser commented on pull request #3928:
URL: https://github.com/apache/hbase/pull/3928#issuecomment-990004738


   > Should this be called in MasterRpcServicces method or here? I can not 
fully recall the suggested pattern...
   
   Heh, I had to ask myself the same question! 
   
   I saw other instances (like `mergeRegions()` 
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L2045-L2051)
 which did this in HMaster rather than in MasterRpcServices. I think this 
change is in the correct place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to