taklwu commented on a change in pull request #3932: URL: https://github.com/apache/hbase/pull/3932#discussion_r766348175
########## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ConfigurableSlowDeterministicMonkeyFactory.java ########## @@ -0,0 +1,98 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.chaos.factories; + +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.chaos.actions.Action; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.lang.reflect.Constructor; +import java.util.function.Function; + +public class ConfigurableSlowDeterministicMonkeyFactory extends SlowDeterministicMonkeyFactory { + + private static final Logger LOG = + LoggerFactory.getLogger(ConfigurableSlowDeterministicMonkeyFactory.class); + + final static String HEAVY_ACTIONS = "heavy.actions"; + final static String TABLE_PARAM = "\\$table_name"; + + public enum SupportedTypes { + FLOAT(p->Float.parseFloat(p)), + LONG(p-> Long.parseLong(p)), + INT(p-> Integer.parseInt(p)), + TABLENAME(p-> TableName.valueOf(p)); + + final Function<String,Object> converter; + + SupportedTypes(Function<String,Object> converter){ + this.converter = converter; + } + + Object convert(String param){ + return converter.apply(param); + } + } + + @Override + protected Action[] getHeavyWeightedActions() { + String actions = this.properties.getProperty(HEAVY_ACTIONS); + if( actions==null||actions.isEmpty() ){ Review comment: [nit] `javac` and `checkstyle` seems failing, please see if you can fix it. ########## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java ########## @@ -322,7 +323,10 @@ protected CommandProvider getCommandProvider(ServiceType service) throws IOExcep case ZOOKEEPER_SERVER: return new ZookeeperShellCommandProvider(getConf()); default: - return new HBaseShellCommandProvider(getConf()); + Class<? extends CommandProvider> provider = getConf() + .getClass("hbase.it.clustermanager.hbase.command.provider", Review comment: [not a blocker][no action required] I found many inline property keys in this class, but you don't need to change it now. but at some point in the future, we may need to move all these `hbase.it.clustermanager.*` to a single place, e.g. `HBaseItClusterMangerConstants` ########## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java ########## @@ -216,7 +217,7 @@ protected String findPidCommand(ServiceType service) { } public String signalCommand(ServiceType service, String signal) { - return String.format("%s | xargs kill -s %s", findPidCommand(service), signal); + return String.format("%s | xargs sudo kill -s %s", findPidCommand(service), signal); Review comment: nice change, this help as long as the user is not the root user, and normally we have the hbase user when using Chaomonkey. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
