apurtell commented on a change in pull request #3936:
URL: https://github.com/apache/hbase/pull/3936#discussion_r768069212
##########
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/TestIntegrationTestBase.java
##########
@@ -40,11 +40,10 @@ public void testMonkeyPropertiesParsing() {
conf.set(MonkeyConstants.BATCH_RESTART_RS_RATIO, "0.85");
conf.set(MonkeyConstants.MOVE_REGIONS_MAX_TIME, "60000");
conf.set("hbase.rootdir", "/foo/bar/baz");
-
final Properties props = new Properties();
- IntegrationTestBase testBase = new IntegrationTestDDLMasterFailover();
assertEquals(0, props.size());
- testBase.loadMonkeyProperties(props, conf);
+ new IntegrationTestDDLMasterFailover();
Review comment:
Because the assignment is flagged as a dead store. This code still
works. The constructor is called. The warning about a dead store is avoided. It
is a trivial issue and I don't care much either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]