Apache9 commented on pull request #3851: URL: https://github.com/apache/hbase/pull/3851#issuecomment-994412034
> Looks great to me. I think I agree with the method layout you have here already, Szabolcs. > > It would be great to land this change this week, but let's give Duo the time to comment back once more :) On the method layout we could do it later, since the related classes are all IA.Private. There are only two things, one is to remove the IS annotation, we should not use it for IA.Public interface. And another concern is catching a RuntimeException. I do not have big concerns here. I think we could get this in this week and then merge the feature branch back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
