[
https://issues.apache.org/jira/browse/HBASE-26589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-26589:
---------------------------------
Description:
I noticed this while investigating test failures resulting from HBASE-26542.
The test in question ({{TestRpcServerSlowConnectionSetup}}) builds a connection
header by populating the {{serviceName}} field with the service descriptor's
{{getFullName()}} method. The value returned by {{getFullName()}} is the
protobuf service's package and name. However, down in {{RpcServer}}, we resolve
the service named by the connection header using the service descriptor's
{{getName()}} method. {{getName()}} returns the protobuf service's name,
without the package.
It is my opinion that this is a bug in the {{RpcServer}}, it should resolve
services using their fully qualified name.
was:
I noticed this while investigating test failures resulting from HBASE-26472.
The test in question ({{TestRpcServerSlowConnectionSetup}}) builds a connection
header by populating the {{serviceName}} field with the service descriptor's
{{getFullName()}} method. The value returned by {{getFullName()}} is the
protobuf service's package and name. However, down in {{RpcServer}}, we resolve
the service named by the connection header using the service descriptor's
{{getName()}} method. {{getName()}} returns the protobuf service's name,
without the package.
It is my opinion that this is a bug in the {{RpcServer}}, it should resolve
services using their fully qualified name.
> Protobuf Services should be resolved by their full name
> -------------------------------------------------------
>
> Key: HBASE-26589
> URL: https://issues.apache.org/jira/browse/HBASE-26589
> Project: HBase
> Issue Type: Bug
> Components: IPC/RPC
> Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
> Reporter: Nick Dimiduk
> Priority: Major
>
> I noticed this while investigating test failures resulting from HBASE-26542.
> The test in question ({{TestRpcServerSlowConnectionSetup}}) builds a
> connection header by populating the {{serviceName}} field with the service
> descriptor's {{getFullName()}} method. The value returned by
> {{getFullName()}} is the protobuf service's package and name. However, down
> in {{RpcServer}}, we resolve the service named by the connection header using
> the service descriptor's {{getName()}} method. {{getName()}} returns the
> protobuf service's name, without the package.
> It is my opinion that this is a bug in the {{RpcServer}}, it should resolve
> services using their fully qualified name.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
