Apache9 commented on pull request #3913:
URL: https://github.com/apache/hbase/pull/3913#issuecomment-996376122
For me I do not like to have a left '{' and right '}' on the same line,
unless there is nothing inside the '{}'.
I think in the old time, the suggest way to have a single line if is to do
not have '{}', but now the best practise is to always have '{}' for if, else,
while, for, etc, to avoid misusage.
So I suggest we just keep the old style, I do not think this is a blocker?
Just update the formatter and do a format.
And to end the checkstyle war, do you have any interest to introduce the
spotless plugin to our project? It can format all the java files with a ecplise
formatter file, add headers, and could even format files other than java.
WDYT?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
