Apache9 commented on a change in pull request #3951:
URL: https://github.com/apache/hbase/pull/3951#discussion_r771778363
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/trace/TableOperationSpanBuilder.java
##########
@@ -82,6 +89,72 @@ public TableOperationSpanBuilder setOperation(final
Operation operation) {
return this;
}
+ // `setContainerOperations` perform a recursive descent expansion of all the
operations
+ // contained within the provided "batch" object.
+
+ public TableOperationSpanBuilder setContainerOperations(final RowMutations
mutations) {
+ final Operation[] ops = mutations.getMutations()
+ .stream()
+ .flatMap(row -> Stream.concat(Stream.of(valueFrom(row)),
unpackRowOperations(row).stream()))
+ .toArray(Operation[]::new);
+ return setContainerOperations(ops);
+ }
+
+ public TableOperationSpanBuilder setContainerOperations(final Row row) {
+ final Operation[] ops =
+ Stream.concat(Stream.of(valueFrom(row)),
unpackRowOperations(row).stream())
+ .toArray(Operation[]::new);
+ return setContainerOperations(ops);
+ }
+
+ public TableOperationSpanBuilder setContainerOperations(
+ final Collection<? extends Row> operations
+ ) {
+ final Operation[] ops = operations.stream()
+ .flatMap(row -> Stream.concat(Stream.of(valueFrom(row)),
unpackRowOperations(row).stream()))
+ .toArray(Operation[]::new);
+ return setContainerOperations(ops);
+ }
+
+ private static Set<Operation> unpackRowOperations(final Row row) {
+ final Set<Operation> ops = new HashSet<>();
+ if (row instanceof CheckAndMutate) {
+ final CheckAndMutate cam = (CheckAndMutate) row;
+ ops.addAll(unpackRowOperations(cam));
+ }
+ if (row instanceof RowMutations) {
+ final RowMutations mutations = (RowMutations) row;
+ ops.addAll(unpackRowOperations(mutations));
+ }
+ return ops;
+ }
+
+ private static Set<Operation> unpackRowOperations(final CheckAndMutate cam) {
+ final Set<Operation> ops = new HashSet<>();
+ final Operation op = valueFrom(cam.getAction());
+ switch (op) {
+ case BATCH:
+ case CHECK_AND_MUTATE:
+ ops.addAll(unpackRowOperations(cam.getAction()));
+ break;
+ default:
+ ops.add(op);
+ }
+ return ops;
+ }
+
+ public TableOperationSpanBuilder setContainerOperations(
Review comment:
Just a simple idea, not sure what is the best way to implement it.
Checked the code, seems not easy to have a key value structure for an
attribute? If we just encode it with a String, like 'Put,1000', seems it will
make searching this attribute a bit harder? But if we introduce another
attribute to store the count, we need to make these two attributes aligned,
which is also a pain...
Anyway, not a big problem for now, could consider it later when we learn
opentelemetry more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
