sunhelly commented on a change in pull request #3800: URL: https://github.com/apache/hbase/pull/3800#discussion_r772227119
########## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/StreamSlowMonitor.java ########## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.io.asyncfs.monitor; + +import static org.apache.hadoop.hbase.io.asyncfs.monitor.ExcludeDatanodeManager.DEFAULT_WAL_EXCLUDE_DATANODE_TTL; +import static org.apache.hadoop.hbase.io.asyncfs.monitor.ExcludeDatanodeManager.DEFAULT_WAL_MAX_EXCLUDE_SLOW_DATANODE_COUNT; +import static org.apache.hadoop.hbase.io.asyncfs.monitor.ExcludeDatanodeManager.WAL_EXCLUDE_DATANODE_TTL_KEY; +import static org.apache.hadoop.hbase.io.asyncfs.monitor.ExcludeDatanodeManager.WAL_MAX_EXCLUDE_SLOW_DATANODE_COUNT_KEY; + +import java.util.Deque; +import java.util.concurrent.ConcurrentLinkedDeque; +import java.util.concurrent.TimeUnit; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.conf.ConfigurationObserver; +import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; +import org.apache.hadoop.hdfs.protocol.DatanodeInfo; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hbase.thirdparty.com.google.common.cache.CacheBuilder; +import org.apache.hbase.thirdparty.com.google.common.cache.CacheLoader; +import org.apache.hbase.thirdparty.com.google.common.cache.LoadingCache; + +/** + * Class for monitor the wal file flush performance. + * Each active wal file has a StreamSlowMonitor. + */ +@InterfaceAudience.Private +public class StreamSlowMonitor implements ConfigurationObserver { + private static final Logger LOG = LoggerFactory.getLogger(StreamSlowMonitor.class); + + /** + * Configure for the min count for a datanode detected slow. + * If a datanode is detected slow times up to this count, then it will be added to the exclude + * datanode cache by {@link ExcludeDatanodeManager#tryAddExcludeDN(DatanodeInfo, String)} + * of this regionsever. + */ + private static final String WAL_SLOW_DETECT_MIN_COUNT_KEY = + "hbase.regionserver.async.wal.min.slow.detect.count"; + private static final int DEFAULT_WAL_SLOW_DETECT_MIN_COUNT = 3; + + /** + * Configure for the TTL of the data that a datanode detected slow. + */ + private static final String WAL_SLOW_DETECT_DATA_TTL_KEY = + "hbase.regionserver.async.wal.slow.detect.data.ttl.ms"; + private static final long DEFAULT_WAL_SLOW_DETECT_DATA_TTL = 10 * 60 * 1000; // 10min in ms + + /** + * Configure for the slow packet process time, a duration from send to ACK. + * It is preferred that this value should not be less than 1s. + */ + private static final String DATANODE_SLOW_PACKET_PROCESS_TIME_KEY = + "hbase.regionserver.async.wal.datanode.slow.packet.process.time.millis"; + private static final long DEFAULT_DATANODE_SLOW_PACKET_PROCESS_TIME = 6000; //6s in ms + + /** + * Configure for the packet flush speed. + * e.g. If the configured slow slow packet process time is larger than 1s, then here 0.1kbs means + * 100B should be processed in less than 1s. + * If the configured slow slow packet process time is larger than 10s, then here 0.1kbs means + * 1KB should be processed in less than 10s. + */ + private static final String DATANODE_SLOW_PACKET_FLUSH_SPEED_KEY = + "hbase.regionserver.async.wal.datanode.slow.packet.flush.speed.kbs"; + private static final double DEFAULT_DATANODE_SLOW_PACKET_FLUSH_SPEED = 0.1; + + private final String name; + // this is a map of datanodeInfo->queued slow PacketAckData + private final LoadingCache<DatanodeInfo, Deque<PacketAckData>> datanodeSlowDataQueue; + private final ExcludeDatanodeManager excludeDatanodeManager; + + private int minSlowDetectCount; + private long slowDataTtl; + private long slowPacketAckMs; + private double slowPacketAckSpeed; + + public StreamSlowMonitor(Configuration conf, String name, + ExcludeDatanodeManager excludeDatanodeManager) { + setConf(conf); + this.name = name; + this.excludeDatanodeManager = excludeDatanodeManager; + this.datanodeSlowDataQueue = CacheBuilder.newBuilder() + .maximumSize(conf.getInt(WAL_MAX_EXCLUDE_SLOW_DATANODE_COUNT_KEY, + DEFAULT_WAL_MAX_EXCLUDE_SLOW_DATANODE_COUNT)) + .expireAfterWrite(conf.getLong(WAL_EXCLUDE_DATANODE_TTL_KEY, + DEFAULT_WAL_EXCLUDE_DATANODE_TTL), TimeUnit.HOURS) + .build(new CacheLoader<DatanodeInfo, Deque<PacketAckData>>() { + @Override + public Deque<PacketAckData> load(DatanodeInfo key) throws Exception { + return new ConcurrentLinkedDeque<>(); + } + }); + LOG.info("New stream slow monitor {}", this.name); + } + + public static StreamSlowMonitor create(Configuration conf, String name) { + return new StreamSlowMonitor(conf, name, new ExcludeDatanodeManager(conf)); + } + + /** + * Check if the packet process time shows that the relevant datanode is a slow node. + * @param datanodeInfo the datanode that processed the packet + * @param packetDataLen the data length of the packet + * @param processTimeMs the process time (in ms) of the packet on the datanode, + * @param lastAckTimestamp the last acked timestamp of the packet on another datanode + * @param unfinished if the packet is unfinished flushed to the datanode replicas + */ + public void checkProcessTimeAndSpeed(DatanodeInfo datanodeInfo, long packetDataLen, + long processTimeMs, long lastAckTimestamp, int unfinished) { + long current = EnvironmentEdgeManager.currentTime(); + // A datanode is suspicious slow if it meets one of the following conditions Review comment: Hi, @Apache9 , sorry for the late reply. I think for the two scenarios you described, the speed check is valid for small packets, and the process time limit is for check for any packets. The default value of "hbase.regionserver.async.wal.datanode.slow.packet.process.time.millis" is 6s, that is for any packets without considering the size processed up to 6s represents a slow datanode existing. But for small packets, since it has small length, the process time on the slow datanode is very likely to be less than 6s. As a result, check the speed of processing small packets is valid here. I think the split point of small and large packets is relevant to the tolerance of the process time. Here 100 bytes and 0.1 default speed means the check of the process time is at least ONE second, actually is [1s,6s]. Any packet processed less than 1s will be passed. And for the default configs here, the speed will only check packets with 100~600 bytes. For packets larger than 600, if the process speed of it is less than 0.1, then the process time of it will be larger than the default config 6s. If you think 100 is a little bit small, for example, set it be 200 means the speed check of the process time is [2s,6s]. But I think a 1s process of the little packet is long enough... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
