[
https://issues.apache.org/jira/browse/HBASE-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288213#comment-13288213
]
Jesse Yates commented on HBASE-6145:
------------------------------------
{quote}
How did you get that Unknown macro message? I don't see it when I run local? W/
the -X flag? I see a version when avro does its stuff.
{quote}
Sorry, that was a jira issue. Apparently it doesn't like $ and { in quotes, it
needs to be in the code section. See the raw output (email) for the right
comment. Or just ignore the "unknown macro" comment and just read as written
(would fix, but can't seem to edit jira comments).
{quote}
On avro, its deprecated. I moved it out of top-level into module where its used
as a). encouraging its deprecation, and b). to get rid of some of the noise
avro was generating each time mvn dipped into a module.
{quote}
Was thinking about this more last night - you make a good point. Let's keep it
down in hbase-server.
{quote}
On hbase-common/pom.xml and surefire '...can/should stay in the
pluginManagement section', I don't think our modules should have a
pluginManagement section. It makes sense in top level or in a module IF this
module had submodules but otherwise a pluginManagement doesn't make sense (as I
understand it). I tried removing them from modules.
{quote}
That seems fair. Doesn't really bother me either way in the end, just wanted a
good reason :)
{quote}
On hbase/pom.xml, assembly:assembly is not deprecated.
{quote}
It still works, but just not encouraged. It looks like its the better way to go
though. +1 on that
{quote}
'In src/assembly/all.xml, this comment is no longer applicable.'
{quote}
Hmmm, that's odd. You might want to try adding a specific includes for the test
classifier. Something like (untested):
{code}
...
+ <moduleSets>
+ <moduleSet>
+ <!-- Enable access to all projects in the current multimodule build.
Eclipse
+ says this is an error, but builds from the command line just fine. -->
+ <useAllReactorProjects>true</useAllReactorProjects>
+ <!-- This should work with more than 1 source module -->
+ <!-- Now, select which projects to include in this module-set. -->
+ <!-- Just add future modules here assuming the wildcare doesn't match -->
+ <includes>
+ <include>org.apache.hbase:hbase-*</include>
+ <include>org.apache.hbase:hbase-*:*:test</include>
+ </includes>
{code}
Also, in the same file, this looks like a little cruft in the latest version:
{code}
+ <binaries>
+ <outputDirectory>lib</outputDirectory>
+ <unpack>false</unpack>
+ <dependencySets>
+ <dependencySet/>
+ </dependencySets>
{code}
I think the dependency sets stuff can be removed.
{quote}
I don't know what NO-MVN-MAN-VER does
{quote}
Its a special tag so eclipse doesn't give a warning that you are overriding the
base version. Cosmetic fix.
{quote}
I suppose. I don't trust mvn to do anything right. Therefore my tendency is to
keep it dumb.
{quote}
Ok, I'll look into it in another ticket at some point.
{quote}
On docbkx, they are built into target/docbkx, and then on site build, copied
under site dir. Similar to javadoc. Keeping it a little independent of site in
case someone is working w/ docbkx only, and not interested in site (This is how
it used work).
{quote}
Ok, +1 on all that movement. Strikes me as a bit of pain and costly, but eh.
Let's get a couple of tickets for the cleanup/fixing so we don't forget.
If you can address the couple of things that were missed because of jira
confusion and we get good QA run, I'm good for commit.
> Fix site target post modularization
> -----------------------------------
>
> Key: HBASE-6145
> URL: https://issues.apache.org/jira/browse/HBASE-6145
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Attachments: 6145v4.txt, site.txt, site2.txt, sitev3.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
