[ 
https://issues.apache.org/jira/browse/HBASE-26614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464176#comment-17464176
 ] 

Andrew Kyle Purtell commented on HBASE-26614:
---------------------------------------------

If the code is annotated Private then there are no concerns from me. 

> Refactor code related to "dump"ing ZK nodes
> -------------------------------------------
>
>                 Key: HBASE-26614
>                 URL: https://issues.apache.org/jira/browse/HBASE-26614
>             Project: HBase
>          Issue Type: Task
>          Components: Zookeeper
>    Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Major
>
> The code starting at {{ZKUtil.dump(ZKWatcher)}} is a small mess -- it has 
> cyclic dependencies woven through itself, {{ZKWatcher}} and 
> {{RecoverableZooKeeper}}. It also initializes a static variable in {{ZKUtil}} 
> through the factory for {{RecoverableZooKeeper}} instances. Let's decouple 
> and clean it up.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to