virajjasani commented on a change in pull request #3972:
URL: https://github.com/apache/hbase/pull/3972#discussion_r776598215
##########
File path: bin/region_mover.rb
##########
@@ -493,11 +493,30 @@ def getFilename(options, targetServer, port)
return filename
end
+def getServersRSGroup(servers, rsgroup_admin, hostname, port)
+ rsgroup = rsgroup_admin.getRSGroupOfServer(Address.fromParts(hostname,
+ java.lang.Integer.parseInt(port)))
+ return rsgroup unless rsgroup.nil?
+ begin
+ server_name = getServerName(servers, hostname, port)
+ regions = getRegions(getConfiguration(), server_name)
+ if !regions.nil? && regions.empty?
+ exit 0
+ else
+ $LOG.warn('The server ' + hostname + ' belongs to no rsgroup. But still
holds regions.')
+ exit 5
+ end
+ rescue java.io.IOException => e
+ $LOG.warn(e)
+ exit 0
Review comment:
Since we want to exit gracefully, we should log it at INFO level
##########
File path: bin/region_mover.rb
##########
@@ -493,11 +493,30 @@ def getFilename(options, targetServer, port)
return filename
end
+def getServersRSGroup(servers, rsgroup_admin, hostname, port)
+ rsgroup = rsgroup_admin.getRSGroupOfServer(Address.fromParts(hostname,
+ java.lang.Integer.parseInt(port)))
+ return rsgroup unless rsgroup.nil?
+ begin
+ server_name = getServerName(servers, hostname, port)
+ regions = getRegions(getConfiguration(), server_name)
+ if !regions.nil? && regions.empty?
Review comment:
Can regions be nil here by any chance? Might have to evaluate this to
confirm:
`ProtobufUtil::getOnlineRegions(connection.getAdmin(ServerName.valueOf(servername)))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
