frostruan commented on a change in pull request #3920:
URL: https://github.com/apache/hbase/pull/3920#discussion_r777224821
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1706,12 +1707,23 @@ public SnapshotResponse snapshot(RpcController
controller,
// get the snapshot information
SnapshotDescription snapshot = SnapshotDescriptionUtils.validate(
request.getSnapshot(), server.getConfiguration());
- server.snapshotManager.takeSnapshot(snapshot);
-
// send back the max amount of time the client should wait for the
snapshot to complete
long waitTime =
SnapshotDescriptionUtils.getMaxMasterTimeout(server.getConfiguration(),
snapshot.getType(), SnapshotDescriptionUtils.DEFAULT_MAX_WAIT_TIME);
- return
SnapshotResponse.newBuilder().setExpectedTimeout(waitTime).build();
+
+ SnapshotResponse.Builder builder =
SnapshotResponse.newBuilder().setExpectedTimeout(waitTime);
+
+ // just to pass the unit tests for all 3.x versions,
+ // the minimum version maybe needs to be modified later
+ if (VersionInfoUtil.currentClientHasMinimumVersion(2, 10)) {
Review comment:
Ok. That's a good idea. I will address it ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
