YutSean commented on a change in pull request #3956:
URL: https://github.com/apache/hbase/pull/3956#discussion_r777263551
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##########
@@ -216,9 +216,7 @@
});
/** Statistics thread schedule pool (for heavy debugging, could remove) */
- private transient final ScheduledExecutorService scheduleThreadPool =
- Executors.newScheduledThreadPool(1,
- new
ThreadFactoryBuilder().setNameFormat("BucketCacheStatsExecutor").setDaemon(true).build());
+ private transient ScheduledExecutorService scheduleThreadPool;
Review comment:
My thought is if we turn the log off according to configuration, it
should be better if we just not create such an object. If keep it as final,
there will be a redundant scheduleThreadPool object on the heap. So that I make
it not final here and create the object when we initialise the bucketcache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
