ndimiduk commented on a change in pull request #3979:
URL: https://github.com/apache/hbase/pull/3979#discussion_r778484786
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##########
@@ -1102,10 +1102,11 @@ private int calculateHashForKey(Cell cell) {
*/
@Override
public KeyValue clone() throws CloneNotSupportedException {
- super.clone();
Review comment:
wtf was this even doing?
##########
File path: hbase-build-configuration/pom.xml
##########
@@ -68,11 +68,6 @@
<activation>
<activeByDefault>false</activeByDefault>
</activation>
- <properties>
Review comment:
Since this check is run by precommit testing only, I'm fine with bumping
this check over to JDK11. Please make sure that test-patch is calling it from
the jdk11 incantation instead of the jdk8 incantation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
