sunhelly commented on a change in pull request #3990:
URL: https://github.com/apache/hbase/pull/3990#discussion_r778518829
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
##########
@@ -398,6 +403,17 @@ public long getWALFileSize() {
return walFileSize;
}
+ @Override
+ public List<String> getWALExcludeDNs() {
+ if (excludeDatanodeManager == null) {
+ return new ArrayList<>();
Review comment:
Thanks, @Apache9. If NULL is returned here, there will be NPE in the
ServerMetricsTmpl.jamon, which calls `for String exclude:
mWrap.getWALExcludeDNs()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
