[ 
https://issues.apache.org/jira/browse/HBASE-26543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469594#comment-17469594
 ] 

Mike Drob commented on HBASE-26543:
-----------------------------------

Are we intending to emulate java behavior for the {{-D}} system properties?

>From 
>https://docs.oracle.com/en/java/javase/17/docs/specs/man/java.html#standard-options-for-java
> 

{noformat}
-Dproperty=value
Sets a system property value. The property variable is a string with no spaces 
that represents the name of the property. The value variable is a string that 
represents the value of the property. If value is a string with spaces, then 
enclose it in quotation marks (for example -Dfoo="foo bar").
{noformat}

So {{-D prop=value}} is not a valid Java-ism, but maybe we want it to be valid 
here?

Also left one comment on the PR. Both of these are advisory, and the PR looks 
likely mergable to me as is.

> HBase shell no longer properly parses several args
> --------------------------------------------------
>
>                 Key: HBASE-26543
>                 URL: https://issues.apache.org/jira/browse/HBASE-26543
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 3.0.0-alpha-1, 2.5.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> shell cli arg parsing is broken:
>  * debug is eating a possible arg
>  * -D handling is consuming part of ARGV without declaring it
>  * -Dfoo=bar no longer works
>  * non-interactive mode is eating a possible arg
>  * top level definitions is eating a possible arg
>  * script2run is being ignored entirely



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to