[ 
https://issues.apache.org/jira/browse/HBASE-26611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469948#comment-17469948
 ] 

Wellington Chevreuil commented on HBASE-26611:
----------------------------------------------

{quote}
Think of you change the SFT implementation for a disabled table from DEFAULT to 
MIGRATION, and then from MIGRATION to FILE, without enabling the table. And 
then once you enabled the table, all the regions will be reopened with FILE, 
then all the data will be lost...
{quote}
Yeah, had not thought about such edge cases. 

{quote}
So maybe we could just add a simple rule, you can not change the SFT 
implementation from MIGRATION to other implementation when the table is 
disabled?
{quote}
Sounds like the simplest solution, otherwise we would need to introduce some 
sort of state tracking in the change of tables/Cfs descriptors,...seems 
unnecessarily complex.

> Changing SFT implementation on disabled table is dangerous
> ----------------------------------------------------------
>
>                 Key: HBASE-26611
>                 URL: https://issues.apache.org/jira/browse/HBASE-26611
>             Project: HBase
>          Issue Type: Sub-task
>          Components: HFile, proc-v2
>            Reporter: Duo Zhang
>            Priority: Critical
>
> As our current design is to have a MIGRATION SFT so when region opens, we 
> will mirror the store files to the dst SFT.
> But for a disabled table, the region will not be reopened so we have no 
> chance to mirror the store files list, so after user enable the table, it may 
> find out that all the store files are gone...



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to