frostruan commented on pull request #3966: URL: https://github.com/apache/hbase/pull/3966#issuecomment-1008042325
> I'm not quite sure whether this is the correct behavior. We call preRollWALWriterRequest and postRollWALWriterRequest in RSRpcServices, so maybe the coprocessor call is only for rpc request? Do you face any real usages which needs to also add the cp calls for backup? > > Thanks. Thanks for reviewing this, duo. No, I don't have need to call cp. Just a little confused when reading code. I thought it maybe should be same behavior, no matter to ask a specific regionserver to roll log or to ask all regionservers to toll log. But I am not sure about this too ...... Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
