ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1010536953
@madrob I applied this patch but reverted your changes to `hbase-build-configuration/pom.xml`. I then reproduced the ErrorProne violation from #3968. The upgraded version of ErrorProne fails with a meaningful error message. Which means, the upgrade here does fix the the pre-commit issue I saw over there. ``` [ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1604,50] error: [RestrictedApi] Should only be called in self or ZKUtil ``` Please revert the change to `hbase-build-configuration/pom.xml`, keeping ErrorProne configured for JDK8, and you have my +1 on this change. If you want me to take it over, let me know. Thanks for the drive-by 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
