ndimiduk commented on pull request #4016: URL: https://github.com/apache/hbase/pull/4016#issuecomment-1011422486
> Is this a best practice? At least in the current hbase code base, we need to depend on the test jar of some modules, for example HBaseTestingUtil is in hbase-server module, and we use it in hbase-mapreduce module. > > You can check the pom definition, we have lots of tests jar dependencies… The `HBaseTestingUtility` is an especially bad example, because it's how we suggest users test their HBase applications (I do see that on branch-2 it's marked as `@deprecated`, with no mention of a replacement). In that sense, it's a part of our public API that is provided by a test jar! I think dependency on a test jar is bad practice and maven authors appear to agree -- you have to go out of your way to have maven produce test jars, they're disabled by default. However, I don't want to hold up the otel improvements on these kinds of layout/organization improvements to our repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
