[ 
https://issues.apache.org/jira/browse/HBASE-26662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478319#comment-17478319
 ] 

Hudson commented on HBASE-26662:
--------------------------------

Results for branch branch-2.4
        [build #274 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/274/]:
 (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/274/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/274/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/274/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/274/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> User.createUserForTesting should not reset UserProvider.groups every time if 
> hbase.group.service.for.test.only is true
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-26662
>                 URL: https://issues.apache.org/jira/browse/HBASE-26662
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.9, 2.6.0
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>             Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>
>
> The _if check_ below will always unnecessarily reset static var 
> _UserProvider.groups_ to a newly created instance of TestingGroups every time 
> `User.createUserForTesting` is called.
> {noformat}
>         if (!(UserProvider.groups instanceof TestingGroups) ||
>             conf.getBoolean(TestingGroups.TEST_CONF, false)) {
>           UserProvider.groups = new TestingGroups(UserProvider.groups);
>         }
> {noformat}
> For tests creating multiple {_}test users{_}, this causes the latest created 
> user to reset _groups_ and all previously created users would now have to be 
> available on the {_}User.underlyingImplementation{_}, which not always will 
> be true.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to