YutSean commented on a change in pull request #4072:
URL: https://github.com/apache/hbase/pull/4072#discussion_r793417453
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
##########
@@ -131,18 +131,6 @@ public void testCurrentOnEmptyCell() throws IOException {
assertNull(r.current());
}
- @Test
- public void testAdvanceTwiceOnEmptyCell() throws IOException {
Review comment:
> Better keep this test but use two assertFalse to confirm that the
second advance call will return false?
After the change, empty list will always return false. I think we could
change the UT's name to testAdvanceMultipieOnEmptyCell and use an arbitrary
value > 2 to assert false. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
