petersomogyi commented on pull request #4101:
URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033767721


   > JRuby appears to be 2-clause bsd (assuming BSDL is not unique to the 
standard BSD license...)
   
   The irb.rb file (and the duplicated method) is originally from Ruby and not 
JRuby: 
https://github.com/ruby/irb/blob/9d7ba836eb1ec8ec71b6a24e9683ba96fe3fb72b/lib/irb.rb#L441-L537
   
   This repository is using BSD 2-Clause which is a Category A license by ASF 
policies: https://www.apache.org/legal/resolved.html#category-a 
   
   > unit test to cover this
   
   I'm not yet sure how to do that. We have [existing 
tests](https://github.com/apache/hbase/blob/master/hbase-shell/src/test/ruby/shell/noninteractive_test.rb#L26-L39)
 for shell command execution throwing exception in non-interactive mode but 
these tests don't use IRB.run underneath.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to