[
https://issues.apache.org/jira/browse/HBASE-26702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489610#comment-17489610
]
Rushabh Shah commented on HBASE-26702:
--------------------------------------
Thank you [~zhangduo] for the review and commit !
> Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain
> histogram.
> --------------------------------------------------------------------------------------
>
> Key: HBASE-26702
> URL: https://issues.apache.org/jira/browse/HBASE-26702
> Project: HBase
> Issue Type: Improvement
> Components: metrics, Replication
> Affects Versions: 1.7.1, 2.3.7, 3.0.0-alpha-3
> Reporter: Rushabh Shah
> Assignee: Rushabh Shah
> Priority: Minor
> Fix For: 2.5.0, 1.7.2, 3.0.0-alpha-3, 2.4.10
>
>
> Currently age of last ship metric is an instance of an Histogram type.
> [Here|https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSourceImpl.java#L58]
> {quote}
> ageOfLastShippedOpHist =
> rms.getMetricsRegistry().getHistogram(SOURCE_AGE_OF_LAST_SHIPPED_OP);
> {quote}
> We can change it to TimeHistogram so that we get the range information also.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
