apurtell commented on a change in pull request #4094:
URL: https://github.com/apache/hbase/pull/4094#discussion_r803941792
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -2699,11 +2701,11 @@ public void checkTableModifiable(final TableName
tableName)
}
}
- public ClusterMetrics getClusterMetricsWithoutCoprocessor() throws
InterruptedIOException {
- return getClusterMetricsWithoutCoprocessor(EnumSet.allOf(Option.class));
+ public ClusterMetrics getClusterMetricsInternal() throws
InterruptedIOException {
+ return getClusterMetricsInternal(EnumSet.allOf(Option.class));
}
- public ClusterMetrics getClusterMetricsWithoutCoprocessor(EnumSet<Option>
options)
+ public ClusterMetrics getClusterMetricsInternal(EnumSet<Option> options)
Review comment:
This isn't a required change, I just did it because everywhere else in
the code the convention is fooInternal, not fooWithoutCoprocessor, and I find
it weird and worth changing. I doubt there are any TOOLS that require this
method but this change isn't necessary either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
