[
https://issues.apache.org/jira/browse/HBASE-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289822#comment-13289822
]
Devaraj Das commented on HBASE-6053:
------------------------------------
@Stack, sorry for getting back so late on this one...
On the questions:
bq. We already have a fundamental class named ServerManager. See in master
package. Naming your new class ServerManager will cause confusion.
Yes, I missed this somehow..
bq. Why we need ServerManager at all? What does it add that is not in our
wrapper scripts starting and stopping servers? (Why do control up in java
rather than in shell scripts w/ easier access to ssh and the shell commands
this java script depends on?
The Java interfaces provides ways to control servers from tests in an easier
way. It basically wraps the scripts. But one could provide alternate
implementations of the interfaces.. Look at the changes in
TestRegionRebalancing where the ServerManager methods are used.
bq. Whats going on here? Are you going to hunt all system properties for those
named w/ a proc_ prefix?
Actually, the proc_ was added so that the ServerManager implementation methods
could do a more precise grep for the hbase processes (sometimes the cmdline is
long and ps doesn't display the Java class name for RegionServer or Master).
BTW the proc_* are already there for the hadoop daemons (look at bin/hadoop
shell script).
> Enhance TestRegionRebalancing test to be a system test
> ------------------------------------------------------
>
> Key: HBASE-6053
> URL: https://issues.apache.org/jira/browse/HBASE-6053
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Priority: Minor
> Attachments: regionRebalancingSystemTest.txt
>
>
> TestRegionRebalancing can be converted to be a system test
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
