ndimiduk commented on pull request #4106: URL: https://github.com/apache/hbase/pull/4106#issuecomment-1039112043
> So for async table, we will create a span when starting the scanner, and once we actually execute a piece of code, we will restore that span? So when will we end the span? For async table, we create the span in `AsyncClientScanner#start`. That span wraps the runnable that starts the async callback chain that handles populating scanner results behind the scenes for the client application. Each callback handles making sure that span is restored to its current context. In the test, there are asserts that confirm this span has ended and with `StatusCode.OK`. Perhaps you are correct that this implementation does not handle error cases. I don't see test code that covers an error while scanning. While the test code asserts the parent-child relationships of spans, it does not cover explicitly the start/end times of those children as relates to their parent. I will look closer here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
