taklwu commented on pull request #41: URL: https://github.com/apache/hbase-connectors/pull/41#issuecomment-1041001036
> yes I believe the assembly module is the only place we need to have this information. > > the stuff that's getting autogenerated right now is the implementation based on the main repo that I mentioned earlier. you can turn it off by removing the plugins that drive the executions `aggregate-licenses` and `concat-NOTICE-files`. sorry if above conversation is a long long time ago, I want to clarify your comment above, if I read all your conversations correctly, @busbey you're basically saying we don't need this PR because below block of `hbase-connectors-assembly` has already been autogenerating the right `LICENSES` and `NOTICE` when we building the tarball. So can we close this PR and HBASE-22338? https://github.com/apache/hbase-connectors/blob/2bfc5f1c078e7530ca6506a397e74fa38668b1a5/hbase-connectors-assembly/pom.xml#L93-L126 I just open another one that fix the `NOTICE.aggregate` #93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
