sunhelly commented on a change in pull request #4105:
URL: https://github.com/apache/hbase/pull/4105#discussion_r807581548
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -4937,11 +4937,11 @@ private CheckAndMutateResult
checkAndMutateInternal(CheckAndMutate checkAndMutat
boolean valueIsNull =
comparator.getValue() == null || comparator.getValue().length ==
0;
if (result.isEmpty() && valueIsNull) {
- matches = true;
- } else if (result.size() > 0 && result.get(0).getValueLength() ==
0 && valueIsNull) {
- matches = true;
+ matches = op != CompareOperator.NOT_EQUAL;
Review comment:
@Apache9 Haven't documented this. But I have discussed this problem with
@GeorryHuang on the wechat before he found the comment pending.
The explanation here is that, NULL check is for equal or not equals, rare
people use conditions like >null or <null. So if here we add LESS and GREATER,
I think it may bring confusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
