apurtell commented on a change in pull request #4063: URL: https://github.com/apache/hbase/pull/4063#discussion_r808382224
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RandomQueueBalancer.java ########## @@ -0,0 +1,53 @@ +/** + + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.ipc; + +import com.google.errorprone.annotations.RestrictedApi; +import java.util.List; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.ThreadLocalRandom; +import org.apache.hadoop.conf.Configuration; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +/** + * Queue balancer that just randomly selects a queue in the range [0, num queues). + */ [email protected] [email protected] +public class RandomQueueBalancer implements QueueBalancer { + private final int queueSize; + private final List<BlockingQueue<CallRunner>> queues; + + public RandomQueueBalancer(Configuration conf, String executorName, List<BlockingQueue<CallRunner>> queues) { + this.queueSize = queues.size(); + this.queues = queues; + } + + @Override public int getNextQueue(CallRunner callRunner) { + return ThreadLocalRandom.current().nextInt(queueSize); + } + + @RestrictedApi(explanation = "Should only be called in tests", link = "", Review comment: Can we not do this? I don't want to tie our code to random Google annotation types given their penchant for breaking changes. A comment would suffice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
