apurtell commented on a change in pull request #4118:
URL: https://github.com/apache/hbase/pull/4118#discussion_r810564493
##########
File path:
hbase-asyncfs/src/test/java/org/apache/hadoop/hbase/io/asyncfs/TestFanOutOneBlockAsyncDFSOutput.java
##########
@@ -72,14 +72,11 @@
HBaseClassTestRule.forClass(TestFanOutOneBlockAsyncDFSOutput.class);
private static final Logger LOG =
LoggerFactory.getLogger(TestFanOutOneBlockAsyncDFSOutput.class);
-
private static DistributedFileSystem FS;
-
private static EventLoopGroup EVENT_LOOP_GROUP;
-
private static Class<? extends Channel> CHANNEL_CLASS;
-
private static int READ_TIMEOUT_MS = 2000;
+ private static final Random RNG = new Random();
Review comment:
Ok. The caveat for replacing Random with TLR is where the existing test
code calls setSeed() for whatever reason. TLR doesn't work because TLR doesn't
support setSeed(). Some tests depend on setting the seed, HFile tests come to
mind, and sometimes they don't. I can be more aggressive in switching to TLR
where we don't really need to call setSeed. It's an option. YDYT @Apache9 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
