Apache9 commented on a change in pull request #4133:
URL: https://github.com/apache/hbase/pull/4133#discussion_r814396076
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
##########
@@ -68,7 +68,7 @@ public void dispose() {
public String getAttemptingUser() {
Optional<UserGroupInformation> optionalUser =
serverWithProvider.getAttemptingUser();
if (optionalUser.isPresent()) {
- optionalUser.get().toString();
+ return optionalUser.get().toString();
Review comment:
Oh, this should be a bug.
##########
File path:
hbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
##########
@@ -53,11 +53,11 @@
* {@link ColumnInterpreter} is used to interpret column value. This class is
* parameterized with the following (these are the types with which the {@link
ColumnInterpreter}
* is parameterized, and for more description on these, refer to {@link
ColumnInterpreter}):
- * @param T Cell value data type
- * @param S Promoted data type
- * @param P PB message that is used to transport initializer specific bytes
- * @param Q PB message that is used to transport Cell (<T>) instance
- * @param R PB message that is used to transport Promoted (<S>) instance
+ * @param <T> Cell value data type
Review comment:
Will this change introduce javadoc warning or checkstyle warning?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMergesSplitsAddToTracker.java
##########
@@ -228,7 +228,7 @@ private void validateDaughterRegionsFiles(HRegion region,
String orignalFileName
List<StoreFileInfo> infos =
region.getRegionFileSystem().getStoreFiles("info");
final MutableBoolean foundLink = new MutableBoolean(false);
infos.stream().forEach(i -> {
- i.getActiveFileName().contains(orignalFileName);
+ assertTrue(i.getActiveFileName().contains(orignalFileName));
if(i.getActiveFileName().contains(untrackedFile)){
Review comment:
assertFalse?
Or both lines could be rewrite as assertThat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
