frostruan commented on a change in pull request #4115:
URL: https://github.com/apache/hbase/pull/4115#discussion_r814901349
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -418,22 +471,33 @@ public boolean isSnapshotDone(SnapshotDescription
expected) throws IOException {
* Currently we have a limitation only allowing a single snapshot per table
at a time. Also we
* don't allow snapshot with the same name.
* @param snapshot description of the snapshot being checked.
+ * @param checkTable check if the table is already taking a snapshot.
Review comment:
This parameter is used for different snapshot backends. For
zk-coordinated snapshot, we need to check if another zk-coordinated snapshot on
the same table is in progress, but for the snapshot procedure, it is
unnecessary.
The basic rule is that,
1. Two zk-coordinated snapshots on the same table cannot be taken at the
same time.
2. Two snapshot procedures on the same table can run at the same time.
3. A zk-coordinated snapshot and a proc-v2 based procedure on the same table
can be taken at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
