apurtell commented on a change in pull request #4050:
URL: https://github.com/apache/hbase/pull/4050#discussion_r815018868
##########
File path: hbase-mapreduce/pom.xml
##########
@@ -322,100 +340,6 @@
</property>
</activation>
<dependencies>
- <dependency>
Review comment:
Oh, I see, some extra refactoring?
##########
File path: hbase-mapreduce/pom.xml
##########
@@ -220,6 +220,24 @@
<scope>compile</scope>
<optional>true</optional>
</dependency>
+ <dependency>
Review comment:
Is this related?
##########
File path: hbase-shaded/hbase-shaded-testing-util/pom.xml
##########
@@ -37,43 +37,8 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
- <version>${hadoop.version}</version>
<type>test-jar</type>
<scope>compile</scope>
- <exclusions>
Review comment:
I don't have a strong opinion about this so will approve the PR but it
would be better to stick with just the changes that are implied by the
description _[HBASE-26691 Replacing log4j with reload4j for branch-2.x]_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
