Apache9 commented on a change in pull request #4096:
URL: https://github.com/apache/hbase/pull/4096#discussion_r815396461
##########
File path: bin/hbase
##########
@@ -751,8 +751,8 @@ elif [ "$COMMAND" = "hbtop" ] ; then
done
fi
- if [ -f "${HBASE_HOME}/conf/log4j-hbtop.properties" ] ; then
- HBASE_HBTOP_OPTS="${HBASE_HBTOP_OPTS}
-Dlog4j.configuration=file:${HBASE_HOME}/conf/log4j-hbtop.properties"
+ if [ -f "${HBASE_HOME}/conf/log4j2-hbtop.properties" ] ; then
+ HBASE_HBTOP_OPTS="${HBASE_HBTOP_OPTS}
-Dlog4j2.configurationFile=file:${HBASE_HOME}/conf/log4j2-hbtop.properties"
Review comment:
Redirecting the log message all the slf4j should be default I think, and
then we could decide whether to actually output it, but changing the log level,
appenders, etc.
And I do not think the error here can be fixed by this change, it seems when
starting hbtop we do not add some slf4j related jars. Should be a sperated
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
