ndimiduk commented on a change in pull request #69:
URL:
https://github.com/apache/hbase-operator-tools/pull/69#discussion_r818703794
##########
File path: hbase-hbck2/README.md
##########
@@ -225,10 +238,12 @@ Command:
-f, --fix fix any replication issues found.
Looks for undeleted replication queues and deletes them if passed the
'--fix' option. Pass a table name to check for replication barrier and
- purge if '--fix'.
+ purge if '--fix'. If -i or --inputFiles is specified, pass one or more
input file names.
+ Each file contains <TABLENAME>, one per line. For example:
+ $ HBCK2 -i replication fileName1 fileName2
reportMissingRegionsInMeta <NAMESPACE|NAMESPACE:TABLENAME>...
- To be used when regions missing from hbase:meta but directories
+ To be used when regions missing from hbase:meta but directories
Review comment:
Another unintentional whitespace change?
##########
File path: hbase-hbck2/README.md
##########
@@ -137,19 +142,22 @@ Command:
Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
If -i or --inputFiles is specified, pass one or more input file names.
Each file contains encoded region names, one per line. For example:
- $ HBCK2 assigns -i fileName1 fileName2
+ $ HBCK2 -i assigns fileName1 fileName2
bypass [OPTIONS] <PID>...
Options:
-o,--override override if procedure is running/stuck
-r,--recursive bypass parent and its children. SLOW! EXPENSIVE!
-w,--lockWait milliseconds to wait before giving up; default=1
- Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
+ Pass one (or more) procedure 'pid's to skip to procedure finish. Parent
Review comment:
Unintentional whitespace change?
##########
File path: hbase-hbck2/README.md
##########
@@ -280,6 +281,9 @@ Command:
of what a userspace encoded region name looks like. For example:
$ HBCK2 unassign 1588230740 de00010733901a05f5a2a3a382e27dd4
Returns the pid(s) of the created UnassignProcedure(s) or -1 if none.
+ If -i or --inputFiles is specified, pass one or more input file names.
Review comment:
This new behavior is surprising to me. It's surprising because the `-i`
is accepted as a global flag but it's arguments come after the subcommand.
That's not a common feature in command line utilities that I'm familiar with.
I'm not convinced this is a good behavior.
##########
File path: hbase-hbck2/README.md
##########
@@ -137,12 +138,13 @@ Command:
Returns the pid(s) of the created AssignProcedure(s) or -1 if none.
If -i or --inputFiles is specified, pass one or more input file names.
Each file contains encoded region names, one per line. For example:
- $ HBCK2 assigns -i fileName1 fileName2
+ $ HBCK2 -i assigns fileName1 fileName2
Review comment:
So should this docstring be `HBCK2 -i fileName1 fileName2 assigns ...` ?
Or maybe don't document `-i` here in the `assigns` subcommand because it's a
"global" feature.
##########
File path: hbase-hbck2/README.md
##########
@@ -91,7 +91,9 @@ The above command with no options or arguments passed will
dump out the _HBCK2_
usage: HBCK2 [OPTIONS] COMMAND <ARGS>
Options:
-d,--debug run with debug output
+ -i, --inputfiles take one or more files to
read the args from
Review comment:
You need document the new argument only once. It looks like the
camel-case version, `inputFiles` is what your parser change accepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
