bbeaudreault commented on pull request #4146: URL: https://github.com/apache/hbase/pull/4146#issuecomment-1059319925
Thanks for the review @ndimiduk > Are there other ways to ensure the execution of a scanner close request? For instance, what if the CallRunner skipped checking for client disconnect and call timeouts for close requests? Are you opposed this change as is, or are you suggesting the CallRunner change in addition? It's a good question, but I think it gets tricky to rely solely on that. For example, what if the call queue is full? So then we go down the path of dropping enqueued requests to make room for close requests. It felt cleaner to rely on priorities, as we do for ensuring that meta requests for example go to high priority. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
