apurtell commented on a change in pull request #4166:
URL: https://github.com/apache/hbase/pull/4166#discussion_r822116792
##########
File path: bin/hbase-daemon.sh
##########
@@ -155,12 +155,20 @@ JAVA=$JAVA_HOME/bin/java
export HBASE_LOG_PREFIX=hbase-$HBASE_IDENT_STRING-$command-$HOSTNAME
export HBASE_LOGFILE=$HBASE_LOG_PREFIX.log
-if [ -z "${HBASE_ROOT_LOGGER}" ]; then
-export HBASE_ROOT_LOGGER=${HBASE_ROOT_LOGGER:-"INFO,RFA"}
+if [ -z "${HBASE_ROOT_LOGGER_LEVEL}" ]; then
+export HBASE_ROOT_LOGGER_LEVEL=${HBASE_ROOT_LOGGER_LEVEL:-"INFO"}
fi
-if [ -z "${HBASE_SECURITY_LOGGER}" ]; then
Review comment:
If provided this string we could munge this string into LOGGER_APPENDER
and LOGGER_LEVEL and warn about the change in environment variable usage for
additional compatibility.
##########
File path: bin/hbase-daemon.sh
##########
@@ -155,12 +155,20 @@ JAVA=$JAVA_HOME/bin/java
export HBASE_LOG_PREFIX=hbase-$HBASE_IDENT_STRING-$command-$HOSTNAME
export HBASE_LOGFILE=$HBASE_LOG_PREFIX.log
-if [ -z "${HBASE_ROOT_LOGGER}" ]; then
Review comment:
If provided this string we could munge this string into LOGGER_APPENDER
and LOGGER_LEVEL and warn about the change in environment variable usage for
additional compatibility.
##########
File path: bin/hbase
##########
@@ -796,10 +799,6 @@ HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
HBASE_OPTS="$HBASE_OPTS -Dhbase.id.str=$HBASE_IDENT_STRING"
HBASE_OPTS="$HBASE_OPTS -Dhbase.root.logger=${HBASE_ROOT_LOGGER:-INFO,console}"
-if [ "x$JAVA_LIBRARY_PATH" != "x" ]; then
Review comment:
Does dropping this hunk affect native Hadoop library support?
I didn't check if this is just a removal of something redundant.
##########
File path:
hbase-asyncfs/src/test/java/org/apache/hadoop/hbase/io/asyncfs/AsyncFSTestBase.java
##########
@@ -96,11 +96,6 @@ protected static void startMiniDFSCluster(int servers)
throws IOException {
createDirsAndSetProperties();
Configuration conf = UTIL.getConfiguration();
- // Error level to skip some warnings specific to the minicluster. See
HBASE-4709
Review comment:
This is good cleanup.
Could also use the Log4JUtils static helpers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
