sunhelly commented on a change in pull request #4174:
URL: https://github.com/apache/hbase/pull/4174#discussion_r824596503
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/FSHLogProvider.java
##########
@@ -90,13 +90,6 @@ public static Writer createWriter(final Configuration conf,
final FileSystem fs,
} else {
LOG.debug("Error instantiating log writer.", e);
}
- if (writer != null) {
Review comment:
Thanks. I think if we change the output variable in the method, we must
make synchronized/volatile for it, or else we can not avoid concurrent modify
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
