frostruan commented on pull request #4225: URL: https://github.com/apache/hbase/pull/4225#issuecomment-1068335723
There are five tests failing. The two tests in TestSnapshotFromAdmin fail because that they are designed for the old synchronous implementation, which is polling result from server periodically, now we use a new implementation, which is blocking on the future until timeout. So I think we can move these two tests directly. The two tests for testing AsyncFlushSnapshot fail because that we always choose to using SnapshotProcedure to take snapshot. If SnapshotProcedure is enabled, master will run a SnapshotProcedure and return a procid to the client, then the client will pull result by the procid. If SnapshotProcedure is disabled, then master will take a zk-coordinated snapshot and the client will keep asking master if the snapshot is finished by calling isSnapshotDone method. So The isSnapshotDone method is only used for zk-coordinated snapshots but in these two tests, we actually run a SnapshotProcedure, which will trigger an UnknownSnapshotException. I'll try to fix these problems as soon as possible. The last failing test org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster.testSnapshotHFileArchiving is not very stable. I haven't find the reason why it failed yet. I'll keep trying. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
