Apache9 commented on a change in pull request #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r830695471
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -297,11 +295,10 @@ public void operationComplete(ChannelFuture future)
throws Exception {
established(ch);
}
}
- }).channel();
+ }).sync().channel();
Review comment:
There is a BufferCallBeforeInitHandler to handle the case for writing
rpc call out before initializing the connection.
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BufferCallBeforeInitHandler.java
That's why we can avoid calling sync in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
