anmolnar commented on a change in pull request #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r830927166
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -85,24 +85,17 @@
private final NettyRpcClient rpcClient;
- // the event loop used to set up the connection, we will also execute other
operations for this
- // connection in this event loop, to avoid locking everywhere.
- private final EventLoop eventLoop;
Review comment:
Yes, that's a remove indicated by the diff.
Just a quick clarification: we didn't make the channel synchronous (at least
that was not my intention, but fixme). I see 2 important changes here:
1. Call (sendRequest()) is coming on the "main" thread (or whatever the
client executes). I removed the logic which marshalled the call to Netty's
eventLoop thread. In other words: HBase code is running on one thread, while
Netty and the callbacks are running on their own.
2. Netty is waiting for the connetion to be established (TCP level) before
giving back the control to HBase. sync() call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
