Apache9 commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1073718956
Haven't look at the code closely yet, but adding 'sync' call to NettyRpcClient is not practical. Our async client implementation assumes the RpcClient implementation is asynchronous, adding sync call in the code path will cause serious performance impact. Please try to follow the old pattern and reconsider your solution again. As I said above, there is a BufferCallBeforeInitHandler to handle the case for writing rpc call out before initializing the connection. https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BufferCallBeforeInitHandler.java If you still have other questions, just ask here and I will try to explain. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
